fix(php) - bug #19
Merged
fix(php) - bug #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttodua tests fail here 🤔 |
but this merger doesn't break other tests, we should fix them separately imo |
|
will push soon |
|
@carlosmiei unfortunately I've spent quite a lot on this, and i think there is some kind of caching, as the tests are failing with different reason on my local and here too sometimes, and when i close & reopen the PR, the specific test no longer fails. cant reproduce this deterministically. maybe this branch was somewhat buggy, idk anyway, atm this PR passes, and the error happening there is unrelated to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.